tools: respect 7 days wait commit-queue with one approval#62498
Open
panva wants to merge 2 commits intonodejs:mainfrom
Open
tools: respect 7 days wait commit-queue with one approval#62498panva wants to merge 2 commits intonodejs:mainfrom
panva wants to merge 2 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
jasnell
approved these changes
Mar 29, 2026
Contributor
|
This will make the cron check every 5 minutes if that PR is ready, I’m not sure this is worth it. It’s also less than ideal that the seven days limit gets hard coded instead of relying on the NCU logic. |
Member
Author
|
Member
Author
|
Alternatively I can check the ncu output string for this condition and skip based on that (rather than applying the failed label). |
Contributor
|
The alternatives I can think of:
I think either (or both, we could actually combined them) would be a preferable approach – the latter in particular would also work for fast-track PRs, which has also been a pain |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Respect 7 days wait time for commit-queueAdd this label to land a pull request using GitHub Actions.
PRs with only 1 approval.
This makes it so that the CQ label can be applied even with just one review and not end up with commit-queue-failedAn error occurred while landing this pull request using GitHub Actions.
because it lacks the second review.