Review requested:

• @nodejs/security-wg

Note that i was able to repro the issue on windows locally; and after applying the revert locally it has not reoccurred yet.

cc @nodejs/libuv

CI: https://ci.nodejs.org/job/node-test-pull-request/72221/

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.71%. Comparing base (e78ccd8) to head (8d72d50).
⚠️ Report is 13 commits behind head on main.

@@           Coverage Diff            @@
##             main   #62497    +/-   ##
========================================
  Coverage   89.70%   89.71%            
========================================
  Files         691      692     +1     
  Lines      213935   214039   +104     
  Branches    41050    41065    +15     
========================================
+ Hits       191907   192015   +108     
+ Misses      14095    14092     -3     
+ Partials     7933     7932     -1     

@jasnell I see the issue on CI runs for #62165 and #62158 and that was one week before the libuv update landed, so I don't think the regression is in libuv. I'll try to run git-bisect if I find a way to reproduce, a Windows machine, and time.

Hmmm.. weird. I haven't been able to reproduce locally on my machine here following the revert.. but then again, this is a really fast machine. If it's a race condition, I have to wonder if system performance has an impact. It failed about 1 out of 10 runs before the revert and 0 out of 10 after the revert. When i'm able to get back to it I'll run the tests longer to see if it shows up without the revert.

CI: https://ci.nodejs.org/job/node-test-pull-request/72244/

10 runs is probably too small a sample to be confident. Are you using the --repeat flag? python tools/test.py -t 9 --repeat 999 'test/parallel/test-http*' 'test/parallel/test-net-*' 'test/parallel/test-tls-*'