inspector: auto collect webstorage data#62145
Open
islandryu wants to merge 7 commits intonodejs:mainfrom
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #62145 +/- ##
==========================================
+ Coverage 89.64% 89.66% +0.01%
==========================================
Files 676 677 +1
Lines 206240 206711 +471
Branches 39514 39582 +68
==========================================
+ Hits 184891 185349 +458
+ Misses 13465 13446 -19
- Partials 7884 7916 +32
🚀 New features to boost your workflow:
|
addaleax
requested changes
Mar 8, 2026
addaleax
approved these changes
Mar 8, 2026
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
Looks good!
I'd still recommend adding a test for UTF-16 characters outside the ISO-8859-1 range (e.g. emoji or Chinese characters)
github-actions
bot
added
request-ci-failed
Contributor
Failed to start CI- Validating Jenkins credentials ✔ Jenkins credentials valid - Starting PR CI job ✘ Failed to start PR CI: 404 Not Foundhttps://github.com/nodejs/node/actions/runs/22820941170 |
Contributor
|
Related test failure: You probably need to skip that test when compiled without SQLite |
added 2 commits
March 9, 2026 12:58
islandryu
force-pushed
the
autoCollectWebStorage
branch
from
8e0c41b to
b278ecc
Compare
Member
Author
|
I changed the implementation to handle the storage keys and values as UTF-16. |
islandryu
force-pushed
the
autoCollectWebStorage
branch
from
b278ecc to
8fc09a7
Compare
Collaborator
addaleax
reviewed
Mar 9, 2026
Co-authored-by: Anna Henningsen <github@addaleax.net>
Collaborator
Renegade334
removed
the
request-ci-failed
addaleax
approved these changes
Mar 10, 2026
| is_local_storage ? local_storage_map_ : session_storage_map_; | ||
| std::optional<StorageMap> storage_map = | ||
| is_local_storage ? std::make_optional<StorageMap>(local_storage_map_) | ||
| : std::make_optional<StorageMap>(session_storage_map_); |
Member
There was a problem hiding this comment.
This is still making full copies – that's proably fine for a inspector feature, but it's an unnecessary set of extra allocations
github-actions
bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Web Storage data collection, which previously required explicitly firing events to send data to DevTools, is now performed automatically within Node.js.
Web Storage will appear in DevTools simply by specifying
--experimental-storage-inspection, without requiring any code changes.This feature relies on the changes introduced in the following change request, so it can be verified with the latest DevTools commit:
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7274801