Closed
Conversation
nodejs-github-bot
added
dependencies
Member
|
it seems a build failure @jasnell |
Member
|
Yes, we can't rely on the auto updater for this or nghttp3 just yet. I'll be working on this soon. |
nodejs-github-bot
changed the title
targos
force-pushed
the
actions/tools-update-ngtcp2
branch
from
e8e3482 to
d115916
Compare
Member
|
Just rebased, fixed the conflict and updated the gyp file. |
targos
force-pushed
the
actions/tools-update-ngtcp2
branch
from
d115916 to
aa87692
Compare
Member
|
@jasnell The update script and build of ngtcp2 should be fixed. Now our quic code needs to be adapted. |
Member
|
Yep, I'll be working on it this next week :-) |
Member
|
Closing in favor of #51291. |
Member
|
The changes to the update script should probably be cherry-picked in #51291. |
Member
|
I opened #51294 with a generalized version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated update of ngtcp2 to 1.1.0.