src: remove unused using declarations in node.cc#33261
Closed
danbev wants to merge 1 commit intonodejs:masterfrom
Closed
src: remove unused using declarations in node.cc#33261danbev wants to merge 1 commit intonodejs:masterfrom
danbev wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
c++
richardlau
approved these changes
May 6, 2020
devnexen
approved these changes
May 6, 2020
cjihrig
approved these changes
May 6, 2020
jasnell
approved these changes
May 6, 2020
3 tasks
Member
|
FWIW We have tooling to catch these. It wasn't flagging instances like the ones fixed in this PR. I've fixed up the tooling so it does: #33268 |
Collaborator
lpinca
approved these changes
May 8, 2020
Contributor
Author
|
Re-run of failing node-test-commit-freebsd ✔️ |
danbev
added a commit
that referenced
this pull request
May 13, 2020
PR-URL: #33261 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Contributor
Author
|
Landed in 7f343c0. |
codebytere
pushed a commit
that referenced
this pull request
May 16, 2020
PR-URL: #33261 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 7, 2020
PR-URL: #33261 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes