X Tutup
Skip to content

src: re-sort the symbol macros#24382

Merged
refack merged 1 commit intonodejs:masterfrom
sam-github:sort-env-symbols
Nov 16, 2018
Merged

src: re-sort the symbol macros#24382
refack merged 1 commit intonodejs:masterfrom
sam-github:sort-env-symbols

Conversation

@sam-github
Copy link
Copy Markdown
Contributor

The symbol macros were almost lexically sorted, but some were misplaced.

I noticed when I added a few, then sorted the symbol block expecting the new ones to just go into the right place, which they did, but a dozen pre-existing ones moved around, too.

I think this could be fast-tracked, it should make no functional difference.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 72 hours to land.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

X Tutup