X Tutup
Skip to content

test: removed literal from assert#16805

Closed
awegrzyn wants to merge 3 commits intonodejs:masterfrom
awegrzyn:assert-messages
Closed

test: removed literal from assert#16805
awegrzyn wants to merge 3 commits intonodejs:masterfrom
awegrzyn:assert-messages

Conversation

@awegrzyn
Copy link
Copy Markdown
Contributor

@awegrzyn awegrzyn commented Nov 6, 2017

Removed literal from assert to display default message.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. module Issues and PRs related to the module subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@awegrzyn @mscdex @Trott @jasnell @cjihrig @gireeshpunathil @mhdawson @apapirovski @MylesBorins @nodejs-github-bot
X Tutup