Draft
Conversation
fix log statement Dockerfile updated / not updated remove -s option remove -b option from help correct and update example options to use current Node.js versions and latest Debian release
5e0f5e1 to
dc5629a
Compare
Contributor
Author
|
This needs more research, as docker-node/build-automation.mjs Line 92 in 0e49bc2 However it has been broken for a while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update -sscript corrupts Yarn version #2411update -hscript help option non-working examples #2412updatescript misleading log when nothing updated #2413Description
In the update.sh script:
Dockerfile, so that the script can judge whether it has done an update or not. This needs to be changed slightly compared to the original code because the text to be parsed is now "ENV YARN_VERSION=1.22.22" with an "=" delimiter.-soption-boption from help textMotivation and Context
Multiple interrelated issues described in #2411, #2412 & #2413 need addressing.
Previous changes removed a function of the script that saved the version of Yarn and ensured that the log message "Dockerfile updated!" / "Dockerfile is already up to date!" was correctly output. This also made sure that the version of Yarn was preserved in the
Dockerfile.The
-soption, that according to the help text is supposed to skip updating Alpine and Yarn, has no relation to any Alpine updates and skipping Yarn updates isn't necessary as Yarn v1 is frozen at version 1.22.22. Yarn is also planned for removal in Node.js 26 images and above.The help text invoked with
./update.sh -hhas several inaccuracies.-bis no longer available8, attempts to update all current versions. alpineon its own also attempts to update all variantsTesting Details
Execute
./update.sh -hand then invoke each one of the listed examples.The message should be "Dockerfile is already up to date!""
Check for changes with
git diff. There should be none.Repeat tests.
NODE_VERSIONinDockerfilein20directory should be updated.Test with explicitly selecting
20.Ensure that repeating an update after "Dockerfile updated!" is displayed on the first attempt should then display
"Dockerfile is already up to date!" on subsequent calls.
Example Output
Types of changes
Checklist