X Tutup
Skip to content

Support for setting orientation inside progressbar widget#39

Merged
a7ul merged 4 commits intonodegui:masterfrom
Uriziel01:master
Aug 22, 2019
Merged

Support for setting orientation inside progressbar widget#39
a7ul merged 4 commits intonodegui:masterfrom
Uriziel01:master

Conversation

@Uriziel01
Copy link
Contributor

It's also a first pull request to validate my workflow is in fact valid for further development.

@a7ul
Copy link
Collaborator

a7ul commented Aug 22, 2019

Wow!
One tiny addition,
I would also add Orientation to the exports here: https://github.com/nodegui/nodegui/blob/master/src/index.ts
@Uriziel01

@Uriziel01
Copy link
Contributor Author

@master-atul Ohhh I overlooked that part, thanks for pointing it out, I've made the change 👍

@a7ul
Copy link
Collaborator

a7ul commented Aug 22, 2019

Merging this. Will go out in next release 🍺

@a7ul a7ul merged commit 2011d51 into nodegui:master Aug 22, 2019
@a7ul
Copy link
Collaborator

a7ul commented Aug 22, 2019

@all-contributors please add @Uriziel01 for code

@allcontributors
Copy link
Contributor

@master-atul

I've put up a pull request to add @Uriziel01! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup