[Fix] [Music] Route note preview to the active editor channel#2899
Draft
RDeckard wants to merge 1 commit intonesbox:mainfrom
Draft
[Fix] [Music] Route note preview to the active editor channel#2899RDeckard wants to merge 1 commit intonesbox:mainfrom
RDeckard wants to merge 1 commit intonesbox:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Original issue: #2437
Note preview in the music editor could play on a different channel than the one targeted by the current editing context.
What
playNote()insrc/studio/editors/music.c.piano.col.Impact
Reviewer question: do we explicitly want tab-based routing (
Tracker → tracker channel,Piano → piano channel) as the intended long-term behavior?