Updates verdor/zip from v0.1.19 to v0.3.5#2845
Draft
imsys wants to merge 3 commits intonesbox:mainfrom
Draft
Conversation
no need for the -DCMAKE_POLICY_VERSION_MINIMUM=3.5 flag anymore.
due to:
zip/src/miniz.h:8503:30: error: comparison is always false due to
limited range of data type [-Werror=type-limits]
8503 | if (((mz_uint64)buf_size > 0xFFFFFFFF) || (uncomp_size >
0xFFFFFFFF)) {
but with the -Wno-type-limits flag
This was referenced Oct 21, 2025
Contributor
|
@imsys FYI: I checked with a fork and it seems like it compiles without issue on Android now, since you've updated gradle. Could you set it as ready to review? https://github.com/Kaleidosium/TIC-80/actions/runs/18674388665/job/53241315668 |
Contributor
|
@imsys Any chance of marking this pull request as ready to review soon? zip has been updated to 0.3.6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no need for the -DCMAKE_POLICY_VERSION_MINIMUM=3.5 flag anymore.