X Tutup
Skip to content

Cast handling fixed#8

Merged
natural merged 2 commits intonatural:masterfrom
iuliux:master
Apr 23, 2012
Merged

Cast handling fixed#8
natural merged 2 commits intonatural:masterfrom
iuliux:master

Conversation

@iuliux
Copy link
Copy Markdown
Contributor

@iuliux iuliux commented Apr 23, 2012

This should fix Issue #6

A new config option is added, objCastMode which can take values drop or ctor

@natural
Copy link
Copy Markdown
Owner

natural commented Apr 23, 2012

Thank you for the code. I truly appreciate the thought and effort.

I'm going to go ahead and merge this, however, there are two things that need to happen afterwards:

  1. I don't like "modes", basically controlling behavior via keywords; I prefer callable objects that the user can then specify
  2. There aren't any tests, but that's easily enough to fix.

I'll work on the changes after the merge. Again, many thanks.

natural pushed a commit that referenced this pull request Apr 23, 2012
@natural natural merged commit 706839d into natural:master Apr 23, 2012
@iuliux
Copy link
Copy Markdown
Contributor Author

iuliux commented Apr 23, 2012

Thank you for the merge.

About the test, I couldn't figure out how tests work (how they assert the result, how to run them). I think that an additional doc about this would be very welcome.

Some other issue that came out from testing this is with regard to java wrapper types (but I'll open a new ticket for this)

@natural
Copy link
Copy Markdown
Owner

natural commented Apr 24, 2012

Added docs for tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

X Tutup