Missing ' \( ' in ' enum ' replacement#89
Missing ' \( ' in ' enum ' replacement#89cspiegel-zepf wants to merge 1 commit intomysql2sqlite:masterfrom
Conversation
The missing ' \( ' did break our schema with column name `print_seitenumbruch`. The string contains 'enum' that got replaced to ' `print_seittext NOT NULL DEFAULT 0'.
|
Thank you for the catch! Actually the PR https://github.com/dumblob/mysql2sqlite/pull/71 already solves this but I am really out of time and thinking I should move this in community hands by creating an org here on GitHub and inviting a few admins. Could you maybe thoroughly review the PR I linked to speed up its merging? Especially the unit tests are of paramount importance. They are new to this repo and they are meant to be run by CI before merging any PR. Do you think you could add the required CI instruction files to the PR to make this all work? If so, I would in the mean time move this repo under a new org I will create and invite you and others as admins in the org to keep the bus factor (https://en.wikipedia.org/wiki/Bus_factor ) as high as possible 😉. |
|
I added the CI file. |
4 participants
The missing
\(did break our schema with column nameprint_seitenumbruch. The string containsenumthat got replaced toprint_seittext NOT NULL DEFAULT 0'.