Improve instructions on how to use this script.#76
Merged
dumblob merged 2 commits intomysql2sqlite:masterfrom Aug 24, 2020
c9845:improved-usage-instructions
Merged
Improve instructions on how to use this script.#76dumblob merged 2 commits intomysql2sqlite:masterfrom c9845:improved-usage-instructions
dumblob merged 2 commits intomysql2sqlite:masterfrom
c9845:improved-usage-instructions
Conversation
…ect the "direct pipe" method as noted in the README. Direct piping to sqlite3 is typically how this script will be used since you get a sqlite database file as a result.
dumblob
requested changes
Aug 24, 2020
mysql2sqlite
Outdated
| "USAGE: mysql2sqlite dump_mysql.sql > dump_sqlite3.sql\n" \ | ||
| " file name - (dash) is not supported, because - means stdin") | ||
| "USAGE:\n"\ | ||
| " - mysql2sqlite dump_mysql.sql > dump_sqlite3.sql\n" \ |
Collaborator
There was a problem hiding this comment.
I think - is superfluous and a bit confusing (the whole line should be copy&pastable IMHO). Could you adjust it? (same goes for the second next line).
mysql2sqlite
Outdated
| " - mysql2sqlite dump_mysql.sql | sqlite3 sqlite.db\n" \ | ||
| "\n" \ | ||
| "NOTES:\n" \ | ||
| " - Dash in filename is not supported, because dash (-) means stdin.") |
Collaborator
There was a problem hiding this comment.
I'd say the leading - here is also superfluous (but this time because it's a plain paragraph, not because it's copy&pastable code 😉).
If you're at it, just add space before the last ) to maintain the code style (which is admittedly not well followed in this script - but there is a huge change to behavior planned and then it'll hopefully get better 😉).
Contributor
Author
|
@dumblob Dashes removed, space added. |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instructions now refect the "direct pipe" method as noted in the README.
Direct piping to sqlite3 is typically how this script will be used since you get a sqlite database file as a result.