fix: align timeout params between sse_client and streamable_http_client#2250
Open
Mritunjaypratapsinghh wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Conversation
Fixes modelcontextprotocol#936 - sse_client: replace hardcoded timeout defaults (5.0/300.0) with shared constants MCP_DEFAULT_TIMEOUT and MCP_DEFAULT_SSE_READ_TIMEOUT - streamable_http_client: add headers, timeout, sse_read_timeout, and auth parameters to match sse_client's interface - Both transports now use consistent defaults from _httpx_utils.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #936
Problem
sse_client and streamable_http_client have inconsistent interfaces:
as direct parameters
used hardcoded defaults (5.0s) instead of the shared MCP_DEFAULT_TIMEOUT (30.0s)
Changes
DEFAULT_SSE_READ_TIMEOUT from _httpx_utils.py
's interface
Backward Compatibility
5.0 to 30.0 (aligns with MCP_DEFAULT_TIMEOUT). Users explicitly passing timeout=5.0 are unaffected