X Tutup
Skip to content

Button implies that review will not be submitted from dropdown #7028

@mntlty

Description

@mntlty

The review UI has a list of submission states in a dropdown

Image

Which looks like the radio buttons on the web
Image

When clicking one, I learned that this would submit the review. This was surprising as I would have expected it to change the pending review state but not submit until I had clicked the button, and also pushed my pending comments.

In addition to notification and changes in the timeline, this could trigger events in a repos that responds to Approved events.

  • Extension version: 0.110.0
  • VSCode Version: 1.100.3 (Universal)
  • OS: Darwin arm64 24.5.0
  • Repository Clone Configuration (single repository/fork of an upstream repository): single
  • Github Product (Github.com/Github Enterprise version x.x.x): github.com

Steps to Reproduce:

  1. Click the caret for review categories
  2. Select an option
  3. A review is submitted with that category without clicking the Approve button

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

      X Tutup