-
Notifications
You must be signed in to change notification settings - Fork 15
Include Exception Properties at FailureDetails #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nytian
wants to merge
5
commits into
main
Choose a base branch
from
nytian/failuredetails
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+877
−15
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
client/src/main/java/com/microsoft/durabletask/ExceptionPropertiesProvider.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
| package com.microsoft.durabletask; | ||
|
|
||
| import javax.annotation.Nullable; | ||
| import java.util.Map; | ||
|
|
||
| /** | ||
| * Provider interface for extracting custom properties from exceptions. | ||
| * <p> | ||
| * Implementations of this interface can be registered with a {@link DurableTaskGrpcWorkerBuilder} to include | ||
| * custom exception properties in {@link FailureDetails} when activities or orchestrations fail. | ||
| * These properties are then available via {@link FailureDetails#getProperties()}. | ||
| * <p> | ||
| * Example usage: | ||
| * <pre>{@code | ||
| * DurableTaskGrpcWorker worker = new DurableTaskGrpcWorkerBuilder() | ||
| * .exceptionPropertiesProvider(exception -> { | ||
| * if (exception instanceof MyCustomException) { | ||
| * MyCustomException custom = (MyCustomException) exception; | ||
| * Map<String, Object> props = new HashMap<>(); | ||
| * props.put("errorCode", custom.getErrorCode()); | ||
| * props.put("retryable", custom.isRetryable()); | ||
| * return props; | ||
| * } | ||
| * return null; | ||
| * }) | ||
| * .addOrchestration(...) | ||
| * .build(); | ||
| * }</pre> | ||
| */ | ||
| @FunctionalInterface | ||
| public interface ExceptionPropertiesProvider { | ||
|
|
||
| /** | ||
| * Extracts custom properties from the given exception. | ||
| * <p> | ||
| * Return {@code null} or an empty map if no custom properties should be included for this exception. | ||
| * | ||
| * @param exception the exception to extract properties from | ||
| * @return a map of property names to values, or {@code null} | ||
| */ | ||
| @Nullable | ||
| Map<String, Object> getExceptionProperties(Exception exception); | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.