fix(sandbox): getInitialCode should not use URL hash without full prefix#3523
Open
Josh-Cena wants to merge 2 commits intomicrosoft:v2from
Open
fix(sandbox): getInitialCode should not use URL hash without full prefix#3523Josh-Cena wants to merge 2 commits intomicrosoft:v2from
Josh-Cena wants to merge 2 commits intomicrosoft:v2from
Conversation
I'm hunting down typescript-eslint/typescript-eslint#8780 (see more context in the issue discussion), and I finally got to `getInitialCode`. It turns out that the hash may start with `#code` but then not start with `#code/`, causing malformed initial code to be parsed.
4 tasks
Member
|
Thanks; you'll need to |
Author
|
That's real speed ^^ I was trying to avoid a local clone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm hunting down typescript-eslint/typescript-eslint#8780 (see more context in the issue discussion), and I finally got to
getInitialCode. It turns out that the hash may start with#codebut then not start with#code/, causing malformed initial code to be parsed.