Bypass the TSServer CRLF bug#767
Merged
orta merged 1 commit intomicrosoft:masterfrom Feb 9, 2021
borodean:ts-server-cr-lf-fix
Merged
Bypass the TSServer CRLF bug#767orta merged 1 commit intomicrosoft:masterfrom borodean:ts-server-cr-lf-fix
orta merged 1 commit intomicrosoft:masterfrom
borodean:ts-server-cr-lf-fix
Conversation
|
|
Contributor
|
Oh! OK, great - I'll give this a run next week, thanks |
Closed
Contributor
|
I've given this PR a run locallay and it worked for me on Windows + ST3 - thanks @borodean |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #765.
The plugin broke in the
masterbranch after adding commit 64991b1. After adding it, whenNodeCommClientreceives a message with an empty header, it tries to read an error fromstderr.TSServer doesn't handle line breaks correctly on Windows (microsoft/TypeScript#3403). Because of this the messages are parsed incorrectly, and the plugin gets into the very piece of code where it now tries to read an error. Before it used to just quit the function at that point and the parsing problem went unnoticed, but now the plugin is stuck trying to read
stderr.I found the information about the method of solving the problem here: ycm-core/ycmd#503.
Hopefully, this will unblock the new release.