Check for key in style before accessing.#757
Merged
orta merged 1 commit intomicrosoft:masterfrom Dec 7, 2020
rgant:sublime4-style_for_scope_fix
Merged
Check for key in style before accessing.#757orta merged 1 commit intomicrosoft:masterfrom rgant:sublime4-style_for_scope_fix
orta merged 1 commit intomicrosoft:masterfrom
rgant:sublime4-style_for_scope_fix
Conversation
Contributor
Author
|
Documentation for scope_for_style is here: https://www.sublimetext.com/docs/api_reference.html Which is what they mean by "documentation bug". |
Contributor
|
Validated this locally - thanks @rgant |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the beta of Sublime Text v4 I get the following error in my console:
I asked in the Sublime Discord about this and wbond responded:
This change is just a check that the key exists (adds support for v4) and is true (support for v3).