Use os.path.relpath on a normalized Packages base path#734
Merged
orta merged 1 commit intomicrosoft:masterfrom Jan 15, 2020
adill:fix/signature-popup-path
Merged
Use os.path.relpath on a normalized Packages base path#734orta merged 1 commit intomicrosoft:masterfrom adill:fix/signature-popup-path
os.path.relpath on a normalized Packages base path#734orta merged 1 commit intomicrosoft:masterfrom
adill:fix/signature-popup-path
Conversation
The previous method fails because it assumes `packages_path` is normalized, yet it will not be when Sublime Text is started via the `subl` command with a non-normalized `PATH` entry (i.e. `PATH=z:\bin\..\tools\sublime_text`)
Contributor
|
The code looks reasonable to me, and I've tested running it on my computer and popups are working fine 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous method fails because it assumes
packages_pathisnormalized, yet it will not be when Sublime Text is started via the
sublcommand with a non-normalized
PATHentry(i.e.
PATH=z:\bin\..\tools\sublime_text)