DOM update 2024-07-12 by sandersn · Pull Request #59259 · microsoft/TypeScript

sandersn · 2024-07-12T21:33:43Z

I'm doing this early in preparation for adding /** @deferred */ comments on callbacks for 5.6.

Changes:

new interface GetHTMLOptions
add ImportMeta.resolve
new interface MediaKeysPolicy
new interface PointerLockOptions
delete empty interface RTCRtpCodecCapability, replace with its base type RTCRtpCodec.
many MDN links are deleted or added
delete interface InnerHTML, inline its property innerHTML where it was used
add TextEvent, with associated event properties
a few new properties on:
- CSSStyleDeclaration
- CanvasState
- ClipboardItem (+ static side)
- Document
- MediaKeys
- MediaSource
- PopStateEvent
add Element..getHTML, .insertAdjacentHTML, .requestPointerLock
Two new events:
- contextlost
- contextrestored
add HTMLTemplateElement.shadowRootClonable, .shadowRootDelegatesFocus, .shadowRootSerializable
new class MediaSourceHandle
remove OffscreenCanvasRenderingContext2D.commit
add ShadowRoot.serializable, .getHTML
URL.canParse's second parameter adds URL to its type; now string | URL
URL adds parse methods
new class ViewTransition
new interface UpdateCallback
type Transferable adds MediaSourceHandle to union

Test baseline changes:

Nothing substantive except the addition of URL.parse and URL.canParse's second parameter now allowing URL.

@deferred

I'm doing this early in preparation for adding `/** @deferred */` comments on callbacks for 5.6.

sandersn · 2024-07-12T21:33:57Z

@typescript-bot test this

sandersn · 2024-07-12T21:37:06Z

@typescript-bot test it

typescript-bot · 2024-07-12T21:37:10Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	👀 Results
`run dt`	✅ Started	👀 Results
`perf test this faster`	✅ Started	👀 Results

jakebailey · 2024-07-12T21:44:44Z

src/lib/dom.generated.d.ts

-    /**
-     * Sets or retrieves a value that you can use to implement your own label functionality for the object.
-     *
-     * [MDN Reference](https://developer.mozilla.org/docs/Web/API/HTMLOptGroupElement/label)
-     */


Why did so many props lose their MDN links?

They probably have done page cleanup, and for example this link is now 404 (or has always been). Found this relevant PR mdn/browser-compat-data#23481

typescript-bot · 2024-07-12T21:56:48Z

Hey @sandersn, the results of running the DT tests are ready.

There were interesting changes:

Branch only errors:

Package: dom-view-transitions
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/dom-view-transitions/dom-view-transitions-tests.ts
  5:1  error  TypeScript@local expected type to be:
  Promise<void>
got:
  Promise<undefined>  @definitelytyped/expect
  7:1  error  TypeScript@local expected type to be:
  Promise<void>
got:
  Promise<undefined>  @definitelytyped/expect
  9:1  error  TypeScript@local expected type to be:
  Promise<void>
got:
  Promise<undefined>  @definitelytyped/expect

/mnt/vss/_work/1/DefinitelyTyped/types/dom-view-transitions/index.d.ts
  6:5  error  TypeScript@local compile error: 
All declarations of 'finished' must have identical modifiers                                                                                                      @definitelytyped/expect
  6:5  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'finished' must be of type 'Promise<undefined>', but here has type 'Promise<void>'            @definitelytyped/expect
  7:5  error  TypeScript@local compile error: 
All declarations of 'ready' must have identical modifiers                                                                                                         @definitelytyped/expect
  7:5  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'ready' must be of type 'Promise<undefined>', but here has type 'Promise<void>'               @definitelytyped/expect
  8:5  error  TypeScript@local compile error: 
All declarations of 'updateCallbackDone' must have identical modifiers                                                                                            @definitelytyped/expect
  8:5  error  TypeScript@local compile error: 
Subsequent property declarations must have the same type.  Property 'updateCallbackDone' must be of type 'Promise<undefined>', but here has type 'Promise<void>'  @definitelytyped/expect

✖ 9 problems (9 errors, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.22_typescript@5.6.0-dev.20240712/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.22_typescript@5.6.0-dev.20240712/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: chrome-apps
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/chrome-apps/test/index.ts
  2182:21  error  TypeScript@local compile error: 
Conversion of type 'Element | null' to type 'HTMLElement' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.
  Type 'Element' is missing the following properties from type 'HTMLElement': accessKey, accessKeyLabel, autocapitalize, dir, and 128 more  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.22_typescript@5.6.0-dev.20240712/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.22_typescript@5.6.0-dev.20240712/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: node/v16
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/node/v16/module.d.ts
  213:13  error  TypeScript@local tsconfig.dom.json compile error: 
Overload signatures must all be optional or required  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.22_typescript@5.6.0-dev.20240712/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.22_typescript@5.6.0-dev.20240712/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

Package: node/v18
Error:

Error: 
/mnt/vss/_work/1/DefinitelyTyped/types/node/v18/module.d.ts
  290:13  error  TypeScript@local tsconfig.dom.json compile error: 
Overload signatures must all be optional or required  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at combineErrorsAndWarnings (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.22_typescript@5.6.0-dev.20240712/node_modules/@definitelytyped/dtslint/dist/index.js:194:28)
    at runTests (/mnt/vss/_work/1/DefinitelyTyped/node_modules/.pnpm/@definitelytyped+dtslint@0.2.22_typescript@5.6.0-dev.20240712/node_modules/@definitelytyped/dtslint/dist/index.js:186:20)

You can check the log here.

typescript-bot · 2024-07-12T21:59:13Z

@sandersn Here are the results of running the user tests with tsc comparing main and refs/pull/59259/merge:

Something interesting changed - please have a look.

Details

azure-sdk

/mnt/ts_downloads/_/m/azure-sdk/build.sh

[MISSING] error TS2322: Type 'string' is not assignable to type 'never'.
- /mnt/ts_downloads/_/m/azure-sdk/test/narrowedTypes.ts(59,9)
- /mnt/ts_downloads/_/m/azure-sdk/test/narrowedTypes.ts(213,9)
- /mnt/ts_downloads/_/m/azure-sdk/test/narrowedTypes.ts(254,11)

effect

tsconfig.base.json

[MISSING] error TS2322: Type 'ArrayBufferLike[]' is not assignable to type 'Iterable<Transferable>'.
- packages/platform/src/Transferable.ts#L105 in tsconfig.base.json

xterm.js

src/tsconfig-library-base.json

[NEW] error TS2386: Overload signatures must all be optional or required.
- file:///mnt/ts_downloads/_/m/xterm.js/node_modules/@types/node/module.d.ts#L107 in src/tsconfig-library-base.json

jakebailey · 2024-07-12T22:00:20Z

This is scary:

/mnt/vss/_work/1/DefinitelyTyped/types/node/v18/module.d.ts
  290:13  error  TypeScript@local tsconfig.dom.json compile error: 
Overload signatures must all be optional or required  @definitelytyped/expect

typescript-bot · 2024-07-12T22:19:12Z

@sandersn
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₀	₃₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,153	_62,153	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,242	_50,242	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,536k (± 0.92%)}	_{192,183k (± 0.02%)}	_{-1,353k (- 0.70%)}	_192,128k	_192,236k	_{p=0.020 n=6}
_{Parse Time}	_{1.30s (± 1.02%)}	_{1.30s (± 0.79%)}	_~	_1.29s	_1.32s	_{p=0.356 n=6}
_{Bind Time}	_0.71s	_0.71s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.44s (± 0.30%)}	_{9.45s (± 0.83%)}	_~	_9.34s	_9.55s	_{p=0.518 n=6}
_{Emit Time}	_{2.76s (± 0.56%)}	_{2.76s (± 0.53%)}	_~	_2.73s	_2.77s	_{p=0.557 n=6}
_{Total Time}	_{14.21s (± 0.20%)}	_{14.22s (± 0.63%)}	_~	_14.11s	_14.33s	_{p=0.468 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_944,114	_944,244	_{+130 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_407,050	_407,079	_{+29 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{1,218,396k (± 0.01%)}	_{1,218,468k (± 0.01%)}	_~	_1,218,388k	_1,218,570k	_{p=0.173 n=6}
_{Parse Time}	_{6.73s (± 0.32%)}	_{6.70s (± 0.84%)}	_~	_6.63s	_6.77s	_{p=0.574 n=6}
_{Bind Time}	_{1.88s (± 0.34%)}	_{1.88s (± 0.58%)}	_~	_1.87s	_1.90s	_{p=0.787 n=6}
_{Check Time}	_{30.63s (± 0.50%)}	_{30.64s (± 0.28%)}	_~	_30.51s	_30.73s	_{p=0.520 n=6}
_{Emit Time}	_{13.64s (± 0.29%)}	_{13.60s (± 0.51%)}	_~	_13.48s	_13.66s	_{p=0.198 n=6}
_{Total Time}	_{52.88s (± 0.31%)}	_{52.81s (± 0.28%)}	_~	_52.63s	_53.00s	_{p=1.000 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,148,730	_2,148,823	_{+93 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_Types	_929,320	_929,343	_{+23 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{2,116,431k (± 0.01%)}	_{2,116,467k (± 0.00%)}	_~	_2,116,379k	_2,116,559k	_{p=0.471 n=6}
_{Parse Time}	_{6.58s (± 0.23%)}	_{6.59s (± 0.25%)}	_~	_6.56s	_6.61s	_{p=0.367 n=6}
_{Bind Time}	_{2.34s (± 0.90%)}	_{2.32s (± 0.27%)}	_{-0.02s (- 0.85%)}	_2.31s	_2.33s	_{p=0.024 n=6}
_{Check Time}	_{70.33s (± 1.06%)}	_{70.80s (± 0.27%)}	_~	_70.52s	_71.00s	_{p=0.173 n=6}
_{Emit Time}	_{0.14s (± 2.95%)}	_0.14s	_~	_~	_~	_{p=0.405 n=6}
_{Total Time}	_{79.38s (± 0.92%)}	_{79.85s (± 0.23%)}	_~	_79.59s	_80.03s	_{p=0.199 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,005	_1,226,005	_~	_~	_~	_{p=1.000 n=6}
_Types	_261,615	_261,615	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,338,375k (± 0.01%)}	_{2,338,735k (± 0.03%)}	_~	_2,337,937k	_2,339,471k	_{p=0.378 n=6}
_{Parse Time}	_{5.06s (± 0.84%)}	_{5.07s (± 0.73%)}	_~	_5.01s	_5.11s	_{p=0.810 n=6}
_{Bind Time}	_{1.90s (± 0.67%)}	_{1.91s (± 0.80%)}	_~	_1.89s	_1.93s	_{p=0.677 n=6}
_{Check Time}	_{34.13s (± 0.33%)}	_{34.13s (± 0.11%)}	_~	_34.06s	_34.17s	_{p=1.000 n=6}
_{Emit Time}	_{3.26s (± 1.68%)}	_{3.24s (± 1.75%)}	_~	_3.19s	_3.34s	_{p=0.574 n=6}
_{Total Time}	_{44.38s (± 0.30%)}	_{44.35s (± 0.18%)}	_~	_44.20s	_44.41s	_{p=1.000 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,226,005	_1,226,005	_~	_~	_~	_{p=1.000 n=6}
_Types	_261,615	_261,615	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,413,418k (± 0.02%)}	_{2,413,049k (± 0.02%)}	_~	_2,412,644k	_2,413,669k	_{p=0.298 n=6}
_{Parse Time}	_{6.33s (± 0.74%)}	_{6.34s (± 0.38%)}	_~	_6.31s	_6.38s	_{p=0.378 n=6}
_{Bind Time}	_{2.02s (± 1.68%)}	_{2.02s (± 0.58%)}	_~	_2.01s	_2.04s	_{p=0.936 n=6}
_{Check Time}	_{40.88s (± 0.27%)}	_{40.81s (± 0.18%)}	_~	_40.72s	_40.88s	_{p=0.298 n=6}
_{Emit Time}	_{3.94s (± 0.78%)}	_{3.92s (± 0.88%)}	_~	_3.89s	_3.97s	_{p=0.296 n=6}
_{Total Time}	_{53.16s (± 0.16%)}	_{53.11s (± 0.15%)}	_~	_53.01s	_53.21s	_{p=0.378 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_258,315	_258,315	_~	_~	_~	_{p=1.000 n=6}
_Types	_104,817	_104,817	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{427,152k (± 0.02%)}	_{427,174k (± 0.02%)}	_~	_427,069k	_427,359k	_{p=0.810 n=6}
_{Parse Time}	_{3.31s (± 0.63%)}	_{3.30s (± 0.57%)}	_~	_3.29s	_3.34s	_{p=0.805 n=6}
_{Bind Time}	_{1.31s (± 1.18%)}	_{1.30s (± 1.05%)}	_~	_1.29s	_1.32s	_{p=0.452 n=6}
_{Check Time}	_{17.77s (± 0.14%)}	_{17.82s (± 0.32%)}	_~	_17.75s	_17.90s	_{p=0.146 n=6}
_{Emit Time}	_{1.64s (± 1.30%)}	_{1.65s (± 0.83%)}	_~	_1.63s	_1.67s	_{p=0.511 n=6}
_{Total Time}	_{24.03s (± 0.18%)}	_{24.08s (± 0.25%)}	_~	_24.00s	_24.14s	_{p=0.261 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₃₅	₃₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_224,565	_224,565	_~	_~	_~	_{p=1.000 n=6}
_Types	_93,734	_93,734	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{369,509k (± 0.03%)}	_{369,569k (± 0.03%)}	_~	_369,465k	_369,744k	_{p=0.689 n=6}
_{Parse Time}	_{3.41s (± 0.97%)}	_{3.43s (± 0.50%)}	_~	_3.41s	_3.46s	_{p=0.295 n=6}
_{Bind Time}	_{1.92s (± 0.27%)}	_{1.92s (± 0.54%)}	_~	_1.91s	_1.94s	_{p=0.928 n=6}
_{Check Time}	_{19.16s (± 0.27%)}	_{19.18s (± 0.38%)}	_~	_19.10s	_19.27s	_{p=0.629 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.50s (± 0.26%)}	_{24.53s (± 0.29%)}	_~	_24.45s	_24.62s	_{p=0.260 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,891,026	_2,891,199	_{+173 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_Types	_978,080	_978,131	_{+51 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,054,687k (± 0.00%)}	_{3,054,766k (± 0.00%)}	_~	_3,054,662k	_3,054,830k	_{p=0.078 n=6}
_{Parse Time}	_{16.96s (± 0.21%)}	_{16.92s (± 0.12%)}	_~	_16.89s	_16.94s	_{p=0.076 n=6}
_{Bind Time}	_{5.13s (± 0.40%)}	_{5.14s (± 0.99%)}	_~	_5.10s	_5.24s	_{p=0.936 n=6}
_{Check Time}	_{89.71s (± 0.22%)}	_{89.70s (± 0.35%)}	_~	_89.31s	_90.22s	_{p=0.936 n=6}
_{Emit Time}	_{29.32s (± 0.44%)}	_{29.23s (± 1.17%)}	_~	_28.90s	_29.86s	_{p=0.261 n=6}
_{Total Time}	_{141.12s (± 0.20%)}	_{140.99s (± 0.41%)}	_~	_140.63s	_142.16s	_{p=0.128 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_267,239	_267,327	_{+88 (+ 0.03%)}	_~	_~	_{p=0.001 n=6}
_Types	_108,815	_108,842	_{+27 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{411,850k (± 0.01%)}	_{411,888k (± 0.02%)}	_~	_411,795k	_411,999k	_{p=0.688 n=6}
_{Parse Time}	_{4.76s (± 0.42%)}	_{4.75s (± 0.72%)}	_~	_4.71s	_4.80s	_{p=0.625 n=6}
_{Bind Time}	_{2.08s (± 1.03%)}	_{2.09s (± 0.82%)}	_~	_2.07s	_2.11s	_{p=0.514 n=6}
_{Check Time}	_{20.75s (± 0.51%)}	_{20.79s (± 0.22%)}	_~	_20.74s	_20.87s	_{p=0.748 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{27.59s (± 0.43%)}	_{27.63s (± 0.25%)}	_~	_27.55s	_27.75s	_{p=0.872 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_510,479	_510,573	_{+94 (+ 0.02%)}	_~	_~	_{p=0.001 n=6}
_Types	_161,600	_161,623	_{+23 (+ 0.01%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{447,786k (± 0.03%)}	_{447,970k (± 0.07%)}	_~	_447,673k	_448,461k	_{p=0.378 n=6}
_{Parse Time}	_{3.15s (± 0.56%)}	_{3.16s (± 1.29%)}	_~	_3.10s	_3.22s	_{p=0.493 n=6}
_{Bind Time}	_{1.17s (± 0.64%)}	_{1.17s (± 0.35%)}	_~	_1.16s	_1.17s	_{p=1.000 n=6}
_{Check Time}	_{17.04s (± 0.51%)}	_{17.00s (± 0.23%)}	_~	_16.96s	_17.07s	_{p=0.519 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{21.36s (± 0.38%)}	_{21.33s (± 0.20%)}	_~	_21.28s	_21.39s	_{p=0.688 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-07-12T23:18:51Z

@sandersn Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59259/merge:

Something interesting changed - please have a look.

Details

Chocobozzz/PeerTube

6 of 12 projects failed to build with the old tsc and were ignored

packages/types-generator/tsconfig.types.json

error TS2386: Overload signatures must all be optional or required.
- file:///mnt/ts_downloads/_/m/PeerTube/client/node_modules/@types/node/module.d.ts#L290 in client/tsconfig.types.json

mattermost/mattermost

2 of 4 projects failed to build with the old tsc and were ignored

webapp/platform/client/tsconfig.build.json

error TS2386: Overload signatures must all be optional or required.
- file:///mnt/ts_downloads/_/m/mattermost/webapp/node_modules/@types/node/module.d.ts#L254 in webapp/platform/types/tsconfig.json
- file:///mnt/ts_downloads/_/m/mattermost/webapp/node_modules/@types/node/module.d.ts#L254 in webapp/platform/client/tsconfig.build.json

vercel/hyper

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2386: Overload signatures must all be optional or required.
- file:///mnt/ts_downloads/_/m/hyper/node_modules/@types/node/module.d.ts#L290 in app/tsconfig.json
- file:///mnt/ts_downloads/_/m/hyper/node_modules/@types/node/module.d.ts#L290 in tsconfig.json

sandersn · 2024-07-15T15:50:32Z

This PR adds ImportMeta.resolve as a non-optional method:

interface ImportMeta {
    url: string;
    resolve(specifier: string): string;
}

But resolve is still experimental-only in node 16 and 18. Node versions really need an associated DOM version instead of all claiming to work with the newest.
(and of course node technically shouldn't depend on the DOM at all.)

sandersn · 2024-07-15T16:47:11Z

After discussing with @andrewbranch we decided to make ImportMeta.resolve required in node 16 and 18 as well. Forcing a null check before usage isn't the right way to handle experimental features in the first place. I'd prefer to delete resolve, but that will break existing dependents of node 16/18.

The correct way would have been to have a separate experimental package, probably.

sandersn · 2024-07-18T18:49:17Z

DefinitelyTyped/DefinitelyTyped#70054 is merged now, so I'm going to merge this after resolving the baseline conflict.

This is consistent with both the API: https://developer.mozilla.org/en-US/docs/Web/API/Element/requestPointerLock#return_value As well as its upcoming inclusion in TypeScript's built-in types for requestPointerLock: https://github.com/microsoft/TypeScript/blob/90da3ca5dd694f7029b535ea09727be899854d40/src/lib/dom.generated.d.ts#L7873 Which was added here: microsoft/TypeScript#59259

Upgrade @types/node to work around an issue in TypeScript [1] that caused our "publish to VSCode Marketplace" github action [2] to fail: ``` node_modules/@types/node/module.d.ts:290:13 - error TS2386: Overload signatures must all be optional or required. 290 resolve?(specified: string, parent?: string | URL): Promise<string>; ``` [1] microsoft/TypeScript#59259 (comment) [2] https://github.com/llvm/vscode-lldb/actions/runs/13298213337/job/37134713009

…6994) Upgrade @types/node to work around an issue in TypeScript [1] that caused our "publish to VSCode Marketplace" github action [2] to fail: ``` node_modules/@types/node/module.d.ts:290:13 - error TS2386: Overload signatures must all be optional or required. 290 resolve?(specified: string, parent?: string | URL): Promise<string>; ``` [1] microsoft/TypeScript#59259 (comment) [2] https://github.com/llvm/vscode-lldb/actions/runs/13298213337/job/37134713009

…e.d.ts (#126994) Upgrade @types/node to work around an issue in TypeScript [1] that caused our "publish to VSCode Marketplace" github action [2] to fail: ``` node_modules/@types/node/module.d.ts:290:13 - error TS2386: Overload signatures must all be optional or required. 290 resolve?(specified: string, parent?: string | URL): Promise<string>; ``` [1] microsoft/TypeScript#59259 (comment) [2] https://github.com/llvm/vscode-lldb/actions/runs/13298213337/job/37134713009

…m#126994) Upgrade @types/node to work around an issue in TypeScript [1] that caused our "publish to VSCode Marketplace" github action [2] to fail: ``` node_modules/@types/node/module.d.ts:290:13 - error TS2386: Overload signatures must all be optional or required. 290 resolve?(specified: string, parent?: string | URL): Promise<string>; ``` [1] microsoft/TypeScript#59259 (comment) [2] https://github.com/llvm/vscode-lldb/actions/runs/13298213337/job/37134713009

DOM update 2024-07-12

5181b2c

I'm doing this early in preparation for adding `/** @deferred */` comments on callbacks for 5.6.

typescript-bot assigned sandersn Jul 12, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 12, 2024

jakebailey reviewed Jul 12, 2024

View reviewed changes

Merge branch 'main' into dom-update-2024-07-12

f202073

sandersn merged commit 121c5dd into microsoft:main Jul 18, 2024

sandersn deleted the dom-update-2024-07-12 branch July 18, 2024 20:02

This was referenced Jul 19, 2024

[chrome-apps] Fix test for TS 5.6 DefinitelyTyped/DefinitelyTyped#70104

Merged

[dom-view-transitions] Fix for TS 5.6 DefinitelyTyped/DefinitelyTyped#70106

Merged

DanielRosenwasser mentioned this pull request Jul 19, 2024

lib.d.ts Updates for TypeScript 5.6 #58764

Closed

trevorade mentioned this pull request Aug 15, 2024

chrome-apps: Update HTMLElement requestPointerLock to return Promise DefinitelyTyped/DefinitelyTyped#70305

Merged

zyhou mentioned this pull request Sep 19, 2024

Typescript v5.6.2 resulting in "Overload signatures must all be optional or required." on alpine linux arm64 #59982

Closed

JDevlieghere mentioned this pull request Feb 13, 2025

[lldb-dap] Upgrade @types/node to fix TS2386 in node/module.d.ts llvm/llvm-project#126994

Merged

sandersn removed this from PR Backlog Apr 22, 2025

az242 mentioned this pull request Jun 9, 2025

Typescript version update breaks chime-sdk-js aws/amazon-chime-sdk-js#3077

Closed

4 tasks

microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025

Conversation

sandersn commented Jul 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sandersn commented Jul 12, 2024

Uh oh!

sandersn commented Jul 12, 2024

Uh oh!

typescript-bot commented Jul 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

typescript-bot commented Jul 12, 2024

Uh oh!

typescript-bot commented Jul 12, 2024

/mnt/ts_downloads/_/m/azure-sdk/build.sh

Uh oh!

jakebailey commented Jul 12, 2024

Uh oh!

typescript-bot commented Jul 12, 2024

tsc

Uh oh!

typescript-bot commented Jul 12, 2024

Uh oh!

sandersn commented Jul 15, 2024

Uh oh!

sandersn commented Jul 15, 2024

Uh oh!

sandersn commented Jul 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sandersn commented Jul 12, 2024 •

edited

Loading

typescript-bot commented Jul 12, 2024 •

edited

Loading