Add error log with mbedtls_ssl_setup error code.#9
Merged
thebentern merged 1 commit intomeshtastic:masterfrom Mar 7, 2026
Merged
Add error log with mbedtls_ssl_setup error code.#9thebentern merged 1 commit intomeshtastic:masterfrom
thebentern merged 1 commit intomeshtastic:masterfrom
Conversation
Author
|
@thebentern would you be able to review? |
thebentern
approved these changes
Mar 5, 2026
There was a problem hiding this comment.
Pull request overview
Adds additional logging to capture the mbedtls_ssl_setup error code when SSL setup fails, to help diagnose intermittent TLS handshake failures.
Changes:
- Log
mbedtls_ssl_setupreturn code on failure. - Preserve existing cleanup path (
mbedtls_ssl_free) after setup failure.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
SSL handshake seems to fail sometimes (meshtastic/firmware#6960) but we need more detail on the mbedtls_ssl_setup error code to identify the problem. 'Web Client Rebuild' group is also seeing some '[HTTPS:E] SSL handshake failed.', we need more info to determine if it's related to the bug report above or something unrelated.
thebentern
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SSL handshake seems to fail sometimes (meshtastic/firmware#6960) but we need more detail on the mbedtls_ssl_setup error code to identify the problem.
'Web Client Rebuild' group is also seeing some '[HTTPS:E] SSL handshake failed.', we need more info to determine if it's related to the bug report above or something unrelated.