feat(excluded_filetypes): Add property to exclude filetypes in which …#1
Merged
meeehdi-dev merged 2 commits intomeeehdi-dev:mainfrom Nov 8, 2024
Merged
feat(excluded_filetypes): Add property to exclude filetypes in which …#1meeehdi-dev merged 2 commits intomeeehdi-dev:mainfrom
meeehdi-dev merged 2 commits intomeeehdi-dev:mainfrom
Conversation
…auto_suggestion should not be used
meeehdi-dev
requested changes
Nov 8, 2024
Owner
meeehdi-dev
left a comment
meeehdi-dev
left a comment
There was a problem hiding this comment.
hi @brunnseb ,
Thank you for your contribution 🙏
The change looks good as is, but i think we can optimize the util function in case someone decides to have a huge array of excluded types.
Author
Makes sense, I updated the |
meeehdi-dev
added a commit
that referenced
this pull request
Nov 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add possibility to exclude certain filetypes from auto_suggestion being run. Manual suggestion still works as before.