Remove LaTeX checking in setup.py.#9571
Conversation
We already have runtime tests for LaTeX and associated dependencies; the check in setup.py is not used for anything.
Kojoley
left a comment
There was a problem hiding this comment.
What is the point? From time to time I found this checks helpful.
|
These checks are already available at runtime (as |
|
It is nice to catch the warning when you install rather than when something fails. |
|
But this only gets executed when installing from source rather than from a wheel or a conda package (which is likely the most common case where the warning would be useful...). |
|
Can we move this to (or do we already have?) a utility function at in the top level namespace like |
|
You mean these? :-) (and a few others) We could unify all these into something like (also including gs and inkscape, so not just latex deps) |
|
Yes, those. We should bundle them up into one summary function? |
|
That's what I proposed above (but you may have missed the edit :-)) |
|
👍 |
We already have runtime tests for LaTeX and associated dependencies; the
check in setup.py is not used for anything.
PR Summary
PR Checklist