Simplify declaration of install_requires.#9536
Merged
Kojoley merged 1 commit intomatplotlib:masterfrom Oct 28, 2017
Merged
Conversation
The previous way of declaring install_requires is way too overengineered now that we unconditionally rely on the standard dependency resolution machinery. Don't use environment markers on install_requires as who knows what version of setuptools & pip does the end user have. Drop the check on Tornado as we don't do anything with it.
Member
|
Not sure if it units as a review, but I used this in a fresh environment on my machine and it installed fine using |
Contributor
dopplershift
left a comment
dopplershift
left a comment
There was a problem hiding this comment.
I'm 👍 on the changes, but I'm not knowledgable about the previous system to know if there was some reason we had all that machinery.
Contributor
Author
|
I'm pretty sure the machinery dates back to when dependency installation was a mess and we used to vendor the dependencies, see https://github.com/matplotlib/matplotlib/wiki/MEP11#current-behavior. |
jklymak
approved these changes
Oct 27, 2017
Member
jklymak
left a comment
jklymak
left a comment
There was a problem hiding this comment.
This works my setup and passes all the tests, which I think all download and setup, so I think this works.
Kojoley
approved these changes
Oct 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous way of declaring install_requires is way too overengineered
now that we unconditionally rely on the standard dependency resolution
machinery.
Don't use environment markers on install_requires as who knows what
version of setuptools & pip does the end user have.
Drop the check on Tornado as we don't do anything with it.
(Done in preparation of declaring a dependency on contextlib2 on Py2 to fix #9521 (comment).)
PR Summary
PR Checklist