If PIL.image is missing, tell user to install pillow#9365
Merged
tacaswell merged 2 commits intomatplotlib:masterfrom Oct 13, 2017
Merged
If PIL.image is missing, tell user to install pillow#9365tacaswell merged 2 commits intomatplotlib:masterfrom
tacaswell merged 2 commits intomatplotlib:masterfrom
Conversation
anntzer
reviewed
Oct 11, 2017
doc/conf.py
Outdated
| __import__(name) | ||
| except ImportError: | ||
| missing.append(name) | ||
| if name == 'PIL.Image': |
Contributor
There was a problem hiding this comment.
just make names a mapping? IPython.blah.blah is likewise technically not the correct name (should be just IPython).
dstansby
force-pushed
the
doc-build-reqs
branch
from
802ed1f to
cb94229
Compare
Member
|
👍 on this. Every six months or so I went through this! |
anntzer
approved these changes
Oct 11, 2017
Contributor
anntzer
left a comment
anntzer
left a comment
There was a problem hiding this comment.
conditional on tests passing (but why would they not)
Member
|
... yet |
Contributor
|
Because |
Member
Author
|
Does that mean the other append statement won't work on python 2 either? |
Contributor
|
... no? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
pillowisn't installed and one tries to build the docs, currently the error message isIt took me a while and a bit of searching that to fix this requires installing the
pillowpackage. This PR changes the error message toto make it much clearer which package is missing and needs to be installed.