Looks like it. I presume this fixes it for you?

My only reservation is that I am fairly sure this is also fixed in another pull request, but I haven't located it yet.

Found it: #851 has a different fix for this bug, so this requires a more careful look, as well as a decision on the status of #851.

Yes, my fix works for me. Ah, #851 uses fig_manager = Gcf.get_active() at line 2267 in backend_bases.py to get the manager, instead of canvas.manager. I have no idea which is better.

My vote is for your method, since "canvas" is what gets passed in, while "Gcf.get_active()" seems like a kludge that happens to work for most situations.

I agree that this method is preferable (and the correct one).

@other devs: In order to merge, can I just press the "Merge pull request" button or should I merge by command line pull & push?

On 06/04/2012 09:35 PM, Phil Elson wrote:

I agree that this method is preferable (and the correct one).

@other devs: In order to merge, can I just press the "Merge pull request" button or should I merge by command line pull& push?

If the button is green, push it!

Quick caveat... always make sure that the PR is to the correct branch first. Also, if you had to do testing of the PR on your system, you might as well do the merging there anyway. Then, if the merge is to the maintenance branch, you will then have to manually perform a merge down to the master branch.

Thanks for fixing this @mspacek, I've merged it onto master.