Missing return in _num_to_string()#8594
Merged
tacaswell merged 1 commit intomatplotlib:masterfrom May 9, 2017
Merged
Conversation
Added a missing return statement that caused "None" strings to be displayed with LogFormatter.
Member
|
I am a bit concerned that nobody has noticed this before? This method appears to be used in the LogFormatter's |
Member
|
I've noticed it before with other formatters but thought it was expected behavior. Wonder if that's what's going on? @FedeMiorelli can you add a test that this now yields the expected labeling? You can add it to the LogFormatter tests. |
Member
|
That does appear to be very broken... Looks like it was broken in 8bdabcd The tests we have of this either a) test Going to merge, backport this, and create a new issue for adding the tests. |
tacaswell
added a commit
that referenced
this pull request
May 9, 2017
FIX: Missing return in LogFormatter._num_to_string()
Member
|
backported to v2.0.x as e273f7e |
Member
|
Wow! I really blew that one. Thanks for finding and fixing it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a missing return statement that caused "None" strings to be displayed with LogFormatter.
PR Summary
PR Checklist