Merged
Conversation
WeatherGod
approved these changes
Apr 28, 2017
Member
|
Is this a problem elsewhere in our docs? I wonder if there is a way for us to detect this reliably, because it is an easy mistake to make. |
phobson
approved these changes
Apr 28, 2017
Contributor
Author
|
it might be, I think the easy thing to do would be to add a docstring checker to the tests, but the problem is that this will generate a ton of errors because many docstrings are outdated :-/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sorry for the barrage of PRs today, but I just noticed that the docstring of
ax.scatterwas getting rendered improperly in thepyplotpage because it doesn't have a period at the end of the first sentence.