X Tutup
Skip to content

Update conda patch for AppVeyor build.#8523

Merged
jenshnielsen merged 1 commit intomatplotlib:masterfrom
QuLogic:fix-appveyor
Apr 22, 2017
Merged

Update conda patch for AppVeyor build.#8523
jenshnielsen merged 1 commit intomatplotlib:masterfrom
QuLogic:fix-appveyor

Conversation

@QuLogic
Copy link
Copy Markdown
Member

@QuLogic QuLogic commented Apr 21, 2017

The change in #8518 broke the patching when building the conda package. This updates the patch so that it should work now.

@QuLogic QuLogic added this to the 2.1 (next point release) milestone Apr 21, 2017
@jenshnielsen
Copy link
Copy Markdown
Member

Shouldn't the default conda backend be Qt5 by now, since thats what new versions of anaconda ships?

Copy link
Copy Markdown
Member

@phobson phobson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff of a diff O_o

@QuLogic
Copy link
Copy Markdown
Member Author

QuLogic commented Apr 21, 2017

Yea, I'm not sure if the backend should change; I'm just trying to get the patch/CI building again. If anyone knows for sure, I'll change it.

@jenshnielsen
Copy link
Copy Markdown
Member

I guess that can always be done. It's probably more important to un brake the build

@jenshnielsen jenshnielsen merged commit e388666 into matplotlib:master Apr 22, 2017
@QuLogic QuLogic deleted the fix-appveyor branch April 22, 2017 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup