Fix autoscaling with twinx and vspans: consider axis with one pair of finite limits ONLY#8513
Merged
dstansby merged 1 commit intomatplotlib:masterfrom Apr 24, 2017
Merged
Conversation
Member
|
@ibnIrshad thanks for the PR and detailed description. This looks good to me. The CI failure from Travis was due to a test that is known to sporadically fail. I've restarted that build. |
phobson
approved these changes
Apr 20, 2017
dstansby
added a commit
that referenced
this pull request
May 1, 2017
Fix autoscaling with twinx and vspans: consider axis with one pair of finite limits ONLY
Member
|
Backported to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Fixes #6284. The problem was that autoscaling was ignoring all axis limits when any of them were infinite. However we should handle this on a case by case basis: If only the x-limits are infinite, we can still use the y-limits, and vice versa. This makes autoscaling work properly with vspans (which only have infinite y-limits).
In order to reproduce the issue (and verify it is fixed), try this:
If fixed, you should see that the vspan does not disappear.
PR Checklist