X Tutup
Skip to content

Fix incorrect text line spacing. #8495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tacaswell merged 5 commits into from
Apr 17, 2017
Merged

Fix incorrect text line spacing. #8495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
09df942
Fixed issue #7523 and added tests for it.
Keerush Apr 15, 2017
e6de9cc
Added png extension to tests.
Keerush Apr 15, 2017
244ee50
Updated tests.
Keerush Apr 16, 2017
04ed906
Updated baseline image name in test.
Keerush Apr 16, 2017
428dc54
Changed test to look at text extents, and removed baseline image.
Keerush Apr 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions lib/matplotlib/tests/test_text.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,3 +421,24 @@ def test_font_scaling():

for i, fs in enumerate(range(4, 43, 2)):
ax.text(0.1, i*30, "{fs} pt font size".format(fs=fs), fontsize=fs)


@pytest.mark.parametrize('spacing1, spacing2', [(0.4, 2), (2, 0.4), (2, 2)])
def test_two_2line_texts(spacing1, spacing2):
text_string = 'line1\nline2'
fig = plt.figure()
renderer = fig.canvas.get_renderer()

text1 = plt.text(0.25, 0.5, text_string, linespacing=spacing1)
text2 = plt.text(0.25, 0.5, text_string, linespacing=spacing2)
fig.canvas.draw()

box1 = text1.get_window_extent(renderer=renderer)
box2 = text2.get_window_extent(renderer=renderer)

# line spacing only affects height
assert box1.width == box2.width
if (spacing1 == spacing2):
assert box1.height == box2.height
else:
assert box1.height != box2.height
1 change: 1 addition & 0 deletions lib/matplotlib/text.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -911,6 +911,7 @@ def get_prop_tup(self, renderer=None):
hash(self._fontproperties),
self._rotation, self._rotation_mode,
self.figure.dpi, id(renderer or self._renderer),
self._linespacing
)

def get_text(self):
Expand Down
X Tutup