X Tutup
Skip to content

Remove useless, confusing check in hist().#8492

Merged
tacaswell merged 1 commit intomatplotlib:masterfrom
anntzer:remove-useless-check-in-hist
Apr 16, 2017
Merged

Remove useless, confusing check in hist().#8492
tacaswell merged 1 commit intomatplotlib:masterfrom
anntzer:remove-useless-check-in-hist

Conversation

@anntzer
Copy link
Copy Markdown
Contributor

@anntzer anntzer commented Apr 15, 2017

_saved_bounds is not used anywhere. It was introduced in c8af84a and even then was only used for numpy<=1.2.

Closes #7754.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is PEP 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/whats_new.rst if major new feature
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

_saved_bounds is not used anywhere.  It was introduced in
c8af84a and even then was only used for
numpy<=1.2.
Copy link
Copy Markdown
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't even know what the "same" reason is.

@QuLogic QuLogic changed the title Remove useless, confusing check in hist(). [MRG+1] Remove useless, confusing check in hist(). Apr 15, 2017
@tacaswell tacaswell merged commit 4efca09 into matplotlib:master Apr 16, 2017
@QuLogic QuLogic changed the title [MRG+1] Remove useless, confusing check in hist(). Remove useless, confusing check in hist(). Apr 16, 2017
@QuLogic QuLogic modified the milestones: 2.0.1 (next bug fix release), 2.1 (next point release) Apr 17, 2017
@anntzer anntzer deleted the remove-useless-check-in-hist branch December 26, 2017 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Forgotten restore bounds?

3 participants

X Tutup