X Tutup
Skip to content

Clarify that Path.contains_x implicitly closes the Path.#8490

Merged
tacaswell merged 1 commit intomatplotlib:masterfrom
anntzer:clarify-contains_x-docstring
Apr 16, 2017
Merged

Clarify that Path.contains_x implicitly closes the Path.#8490
tacaswell merged 1 commit intomatplotlib:masterfrom
anntzer:clarify-contains_x-docstring

Conversation

@anntzer
Copy link
Copy Markdown
Contributor

@anntzer anntzer commented Apr 15, 2017

Also minor rewordings, markup fixes.

Closes #8038.

Also minor rewordings, markup fixes.
@tacaswell
Copy link
Copy Markdown
Member

How did you come to the conclusion that this is the case?

@anntzer
Copy link
Copy Markdown
Contributor Author

anntzer commented Apr 16, 2017

This can easily be tested:

In [3]: matplotlib.path.Path([[0, 0], [0, 1], [1, 1], [1, 0]]).contains_points([[.5, .5], [-.5, -.5]])
Out[3]: array([ True, False], dtype=bool)

(additionally, the other behavior doesn't make much sense)

@tacaswell tacaswell added this to the 2.0.1 (next bug fix release) milestone Apr 16, 2017
@tacaswell tacaswell merged commit 95a5df9 into matplotlib:master Apr 16, 2017
tacaswell added a commit that referenced this pull request Apr 16, 2017
DOC: Clarify that Path.contains_x implicitly closes the Path.
@tacaswell
Copy link
Copy Markdown
Member

backported to v2.0.x as 4a61d3a

@anntzer anntzer deleted the clarify-contains_x-docstring branch April 16, 2017 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Question on Path.contains_point/s

2 participants

X Tutup