Build docs with oldest numpy on 2.7.#8488
Merged
QuLogic merged 1 commit intomatplotlib:masterfrom Apr 17, 2017
Merged
Conversation
Contributor
Author
|
Well, looks like the docs don't build on numpy 1.7.1 :-) |
anntzer
force-pushed
the
one-fewer-travis-job
branch
from
b1fb778 to
1b3b8d0
Compare
Contributor
Author
|
"fixed" |
anntzer
force-pushed
the
one-fewer-travis-job
branch
from
1b3b8d0 to
65f09c1
Compare
Contributor
Author
|
for real this time. |
phobson
approved these changes
Apr 16, 2017
phobson
changed the title
tacaswell
requested changes
Apr 16, 2017
Member
tacaswell
left a comment
tacaswell
left a comment
There was a problem hiding this comment.
This means we don't run the test suite, only build the docs on py2.7.
Contributor
Author
|
Ah, I see, misunderstood BUILD_DOCS. Let's build the docs with 2.7+oldest numpy then? |
anntzer
force-pushed
the
one-fewer-travis-job
branch
from
65f09c1 to
5e249f1
Compare
Some examples needed to be fixed to build on python2.7+numpy1.7. Delete examples/misc/rec_join_demo.py which is not working on numpy 1.7.1 -- not fixing it, as rec_join is arguably better provided by pandas-style librairies anyways.
anntzer
force-pushed
the
one-fewer-travis-job
branch
from
5e249f1 to
5d64f54
Compare
tacaswell
approved these changes
Apr 17, 2017
QuLogic
changed the title
Member
|
Don't really need to wait for AppVeyor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saving some more time on CI, and checking that the docs build with old
numpys as well.
#8232 could probably be closed after that.