X Tutup
Skip to content

Improve hist2d docstring by inlining properties.#8435

Merged
NelleV merged 1 commit intomatplotlib:masterfrom
anntzer:hist2d-docstring
Apr 6, 2017
Merged

Improve hist2d docstring by inlining properties.#8435
NelleV merged 1 commit intomatplotlib:masterfrom
anntzer:hist2d-docstring

Conversation

@anntzer
Copy link
Copy Markdown
Contributor

@anntzer anntzer commented Apr 6, 2017

Followup to #8429.

Copy link
Copy Markdown
Member

@dstansby dstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 apart from my one comment (which may just be me being confused)


norm : Normalize, optional
A :class:`matplotlib.colors.Normalize` instance is used to scale
luminance data to ``[0, 1]``. If not set, defaults to `Normalize`.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If not set, defaults to Normalize.

What does that mean? Does it default to Normalize with defualt kwargs?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, should have been Normalize() with double backticks. Fixed.

@dstansby dstansby added this to the 2.0.1 (next bug fix release) milestone Apr 6, 2017
@anntzer anntzer force-pushed the hist2d-docstring branch from 284aaee to 39636bc Compare April 6, 2017 17:43
@NelleV NelleV merged commit a95a278 into matplotlib:master Apr 6, 2017
@anntzer anntzer deleted the hist2d-docstring branch April 6, 2017 19:56
tacaswell pushed a commit that referenced this pull request Apr 14, 2017
Improve hist2d docstring by inlining properties.
@tacaswell
Copy link
Copy Markdown
Member

backported to v2.0.x as 0c5ab82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

X Tutup