DOC: Show off FuncFormatter as a decorator#8396
Merged
NelleV merged 2 commits intomatplotlib:masterfrom Mar 29, 2017
Merged
Conversation
NelleV
approved these changes
Mar 29, 2017
anntzer
reviewed
Mar 29, 2017
| ax.xaxis.set_major_locator(ticker.MultipleLocator(1.00)) | ||
| ax.xaxis.set_minor_locator(ticker.MultipleLocator(0.25)) | ||
| ax.xaxis.set_major_formatter(ticker.FuncFormatter(major_formatter)) | ||
| ax.xaxis.set_major_formatter(major_formatter) |
Contributor
There was a problem hiding this comment.
I missed the PR, but I think if you really want to suggest using decorator syntax, you can do even better with
@ax.xaxis.set_major_formatter
@ticker.FuncFormatter
def _(x, pos):
return ...
Member
Author
There was a problem hiding this comment.
That's pretty cool, but I think it's a little too clever for the examples/gallery.
My main goal to show how to explicitly act on the Axes/Axis objects and avoid nested function calls.
Contributor
There was a problem hiding this comment.
That's fair.
As a side note this file should be renamed tick_formatters.py consistently with other examples which have importable names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a minor update to an example that shows how to use
ticker.FuncFormatteras a decorator.Also modified example to use the figure object instead of the state machine.