Merged
Conversation
QuLogic
reviewed
Mar 25, 2017
examples/units/artist_tests.py
Outdated
| their axes parent, so you must init the artists with the axes instance | ||
| if you want to initialize them with unit data, or else they will not | ||
| The axis handles unit conversions and the artists keep a pointer to | ||
| their axis parent, so you must initialize the artists with the axis instance |
Member
There was a problem hiding this comment.
I'm thinking this is still a bit long; can you break the sentence in two: "their axis parent. You must initialize ..."?
examples/units/bar_demo2.py
Outdated
|
|
||
| plot using a variety of cm vs inches conversions. The example shows | ||
| how default unit instrospection works (ax1), how various keywords can | ||
| A plot using a variety of centimetre vs inches conversions. This example shows |
Member
There was a problem hiding this comment.
vs inches -> and inch
Is this line not too long? Or is everything else just wrapped a bit short?
Contributor
|
Perhaps it would be helpful to add a comment that the module |
anntzer
approved these changes
Apr 16, 2017
Member
Author
|
Backported to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds in all the comments from #8254