MNT: cleanup whitespace around @_preprocess decorator#8372
MNT: cleanup whitespace around @_preprocess decorator#8372NelleV merged 2 commits intomatplotlib:masterfrom
Conversation
lib/matplotlib/axes/_axes.py
Outdated
| "linelengths", "linewidths", | ||
| "colors", "linestyles"], | ||
| label_namer=None) | ||
| "linelengths", "linewidths", |
There was a problem hiding this comment.
still wrong.
feel free to clear review once this is fixed.
phobson
force-pushed
the
minor-axes-whitespace
branch
from
fec7125 to
a076e3f
Compare
|
I thought there was a general policy of no PEP8-only changes? (although personally I'm happy with them) |
|
I don't know if there is an official policy, but I am concerned that this will create a lot of conflicts with opened pull requests. pep8-patches are a pain to rebase against. |
|
@NelleV that's an excellent point. happy to toss this out |
QuLogic
left a comment
QuLogic
left a comment
There was a problem hiding this comment.
Fortunately, I think everything you've touched has already been the subject of a numpydoc PR, except for eventplot, so there probably won't be very many issues.
lib/matplotlib/axes/_axes.py
Outdated
| 'facecolors', 'color'], | ||
| label_namer="y") | ||
| "edgecolors", "c", 'facecolor', | ||
| 'facecolors', 'color'], |
There was a problem hiding this comment.
Can you make these use consistent quotes?
QuLogic
changed the title
|
@phobson You'll need to rebase. |
phobson
force-pushed
the
minor-axes-whitespace
branch
from
91bfa00 to
f4c4388
Compare
|
@NelleV thanks for the heads up. I found some sketchy wifi and rebased. |
phobson
changed the title
5 participants
No description provided.