DOC: Fix typos in gridspec tutorial#8364
Merged
NelleV merged 3 commits intomatplotlib:v2.0.0-docfrom Mar 23, 2017
Merged
Conversation
tacaswell
approved these changes
Mar 23, 2017
Member
tacaswell
left a comment
tacaswell
left a comment
There was a problem hiding this comment.
Makes markup better and does not make English worse.
tacaswell
changed the title
Contributor
Author
|
@NelleV and @tacaswell , thanks :) |
phobson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just had to use the tutorial about
matplotlib.gridspecand notice a few typos (I think). So here is a PR that should fix them. Being there, I tried to add a few Sphinx cross-references where I think they might be relevant. I tried to build the docs to see if everything was working properly, but I was thrown an error (subprocess.CalledProcessError: Command '['python', '../examples/frontpage/plot_contour.py']' returned non-zero exit status 1) and I have no time to investigate it at the moment. But maybe it is just me and my first try of working on the v2.0.0-doc branch ^^…I had the feeling that the English is not perfect (some sentences sound weird to my ears), but I am quite out of my depth when it comes to this field…