X Tutup
Skip to content

Add simple ax.arrow test#8344

Merged
tacaswell merged 2 commits intomatplotlib:masterfrom
dstansby:arrow-test
Apr 12, 2017
Merged

Add simple ax.arrow test#8344
tacaswell merged 2 commits intomatplotlib:masterfrom
dstansby:arrow-test

Conversation

@dstansby
Copy link
Copy Markdown
Member

Currently ax.arrow is not tested at all!

This adds a simple test, which should help catch anything backwards-incompatible changed as arrow plotting is overhauled.

@dstansby dstansby added this to the 2.1 (next point release) milestone Mar 19, 2017
@anntzer
Copy link
Copy Markdown
Contributor

anntzer commented Mar 19, 2017

Perhaps you can squeeze in tests for a few more kwargs too?

@dstansby
Copy link
Copy Markdown
Member Author

dstansby commented Apr 9, 2017

Okay, this is a bit more complicated now, but gives ax.arrow a good workout! Please don't merge before #8452

@anntzer anntzer mentioned this pull request Apr 10, 2017
@tacaswell tacaswell closed this Apr 10, 2017
@tacaswell tacaswell reopened this Apr 10, 2017
@tacaswell
Copy link
Copy Markdown
Member

powercycled to re-run the tests

@tacaswell tacaswell merged commit d16c4a1 into matplotlib:master Apr 12, 2017
tacaswell added a commit that referenced this pull request Apr 12, 2017
FIX/TST: Add simple ax.arrow test
Conflicts:
    lib/matplotlib/tests/test_axes.py
      - only keep the test added in PR
@tacaswell tacaswell modified the milestones: 2.0.1 (next bug fix release), 2.1 (next point release) Apr 12, 2017
@tacaswell
Copy link
Copy Markdown
Member

backported to v2.0.x as 46247c7

@dstansby dstansby deleted the arrow-test branch May 20, 2017 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

X Tutup