Removes OldScalarFormatter #7956 by NinadBhat · Pull Request #8295 · matplotlib/matplotlib

NinadBhat · 2017-03-14T18:35:52Z

#7956
http://matplotlib.org/examples/pylab_examples/newscalarformatter_demo.html: drop OldScalarFormatter (which should probably be deprecated anyways...)

dstansby

Since there's no longer an 'old' or 'new' method, could you rename the file to just scalarformatter_demo.py?

NelleV · 2017-03-14T18:55:11Z

I am sorry… Could you rename the file to plot_scalarformatter.py? We are currently migrating to sphinx-gallery, and it is possible that we will have to rename everything to plot_XX, so better renaming once than several times :)

NinadBhat · 2017-03-14T18:56:32Z

@NelleV should it be plot_scalarformatter.py or plot_scalarformatter_demo.py?

NelleV · 2017-03-14T19:12:37Z

This looks good to me. I am going to make a couple of additional suggestions, but feel free to ignore those:

Can you add a docstring and a title to this example, describing what the example shows? I can't say this is a great example, but here is an example of a docstring that describes what the example does: https://github.com/matplotlib/matplotlib/blob/master/examples/ticks_and_spines/plot_spines_bounds.py
If you do add a docstring and a title, I think this example could fit in our "ticks and spines" category. Do not move it if you don't fullfill the first point, as this is going to break the migration to sphinx-gallery PR.

Thanks a lot for your contribution!

NinadBhat · 2017-03-14T19:41:50Z

@NelleV : I have tried to add a description let me know if this is ok or if futher improvment is needed.

I don't know what "ticks and spines" category is. Can you kindly explain?

Thanks

NelleV · 2017-03-14T23:52:17Z

@NinadBhat it's one of the category of our gallery. You can switch galleries by switching the folder in which the example lies. Right now, the example is in the folder examples/pylab_examples. To switch it to the ticks and spines category, just move the file in examples/ticks_and_spines.

NelleV · 2017-03-14T23:53:05Z

examples/pylab_examples/plot_scalarformatter.py

-from matplotlib.ticker import OldScalarFormatter, ScalarFormatter
+"""
+===========================
+Example For ScalerFromatter


There is a small typo here: (ScalerFromatter -> ScalerFormatter).

"Tick formatting using the ScalerFormatter" may be a better title?

And Scalar, not Scaler.

NelleV · 2017-03-14T23:53:20Z

examples/pylab_examples/plot_scalarformatter.py

-ax2.plot(x * 1e5, x * 1e-4)
-ax2.xaxis.set_major_formatter(OldScalarFormatter())
-ax2.yaxis.set_major_formatter(OldScalarFormatter())
+The example shows use of ScalerFormater with different settings.


Another type here: ScalerFormater -> ScalerFormatter.

Here too "Scalar"

NinadBhat · 2017-03-15T04:10:17Z

@NelleV and @dopplershift sorry for the typos. I have made changes and moved the file to examples/ticks_and_spines.

NelleV · 2017-03-16T16:21:50Z

examples/ticks_and_spines/plot_scalarformatter.py

-from matplotlib.ticker import OldScalarFormatter, ScalarFormatter
+"""
+=========================================
+Tick formatting using the ScalarFromatter


There is still a typo here (that I am fine fixing just before merging).

NelleV

LGTM 👍

NinadBhat · 2017-03-16T18:01:10Z

examples/tests/backend_driver.py

    'multiple_figs_demo.py',
    'nan_test.py',
-    'newscalarformatter_demo.py',
+    'plot_scalarformatter.py',


@NelleV: This should go to files['ticks_and_spines'] right?

If I understood properly from a conversation with @tacaswell, this file is way out of date and unmaintained.
@tacaswell can you confirm or correct this?

Maybe you're thinking of #8069?

No I think of a later discussion (last week or so)

Once #8069 goes through all these explicit example file references will be gone anyway, so I don't think this matters.

caused by matplotlib/matplotlib#8295

Removes OldScalarFormatter

27de919

dstansby reviewed Mar 14, 2017

View reviewed changes

dstansby added this to the 2.0.1 (next bug fix release) milestone Mar 14, 2017

dstansby added the Documentation label Mar 14, 2017

Renaming file to scalarformatter_demo.py

71a4eb8

Renaming to plot_scalarformatter.py

a8af90e

Adds title and description

a218217

changing name in backend_driver.py

eab3d7f

NelleV reviewed Mar 14, 2017

View reviewed changes

Correcting typos and moving file to ticks and spines

375fd31

NelleV reviewed Mar 16, 2017

View reviewed changes

NelleV approved these changes Mar 16, 2017

View reviewed changes

NelleV changed the title ~~Removes OldScalarFormatter #7956~~ [MRG+1] Removes OldScalarFormatter #7956 Mar 16, 2017

NinadBhat commented Mar 16, 2017

View reviewed changes

dstansby changed the title ~~[MRG+1] Removes OldScalarFormatter #7956~~ [MRG+2] Removes OldScalarFormatter #7956 Mar 17, 2017

dstansby approved these changes Mar 17, 2017

View reviewed changes

NelleV merged commit 7a152d8 into matplotlib:master Mar 17, 2017

QuLogic modified the milestones: 2.1 (next point release), 2.0.1 (next bug fix release) Mar 17, 2017

QuLogic changed the title ~~[MRG+2] Removes OldScalarFormatter #7956~~ Removes OldScalarFormatter #7956 Mar 17, 2017

saraedum added a commit to saraedum/sage-flatsurf that referenced this pull request Nov 18, 2022

Ignore warning on old versions of SageMath

afdb58a

caused by matplotlib/matplotlib#8295

Uh oh!

Conversation

NinadBhat commented Mar 14, 2017

Uh oh!

dstansby left a comment

Choose a reason for hiding this comment

Uh oh!

NelleV commented Mar 14, 2017

Uh oh!

NinadBhat commented Mar 14, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NelleV commented Mar 14, 2017

Uh oh!

NinadBhat commented Mar 14, 2017

Uh oh!

NelleV commented Mar 14, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NinadBhat commented Mar 15, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

NelleV left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

NinadBhat commented Mar 14, 2017 •

edited

Loading