X Tutup
Skip to content

Addresses #8177, Readme badges#8178

Merged
dstansby merged 4 commits intomatplotlib:masterfrom
epintozzi:readme_badges
Mar 2, 2017
Merged

Addresses #8177, Readme badges#8178
dstansby merged 4 commits intomatplotlib:masterfrom
epintozzi:readme_badges

Conversation

@epintozzi
Copy link
Copy Markdown
Contributor

Added badges for: Travis, Appveyor, Codecov, pypi, gitter, and depsy

@anntzer
Copy link
Copy Markdown
Contributor

anntzer commented Mar 2, 2017

I would suggest a plain text gitter link next to the mailing-list section.

You can also update the pypi link so that it points directly to pypi rather than via a redirection.

PS for whoever is reviewing this: you can check how it looks like at https://github.com/epintozzi/matplotlib/tree/readme_badges.

@tacaswell tacaswell added this to the 2.0.1 (next bug fix release) milestone Mar 2, 2017
@tacaswell
Copy link
Copy Markdown
Member

Can we be vain and not include codecov? 😈

Agree on including text link to gitter with the mailing lists

the 'view' button in the review page will also show you the rendering.

Copy link
Copy Markdown
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor preference for a text link to gitter, but fine with this going in as-is.

Please backport to 2.0.0-doc

@QuLogic QuLogic mentioned this pull request Mar 2, 2017
@dstansby
Copy link
Copy Markdown
Member

dstansby commented Mar 2, 2017

I'll consider that a positive review @tacaswell, and merge!

@dstansby dstansby merged commit 1f173dd into matplotlib:master Mar 2, 2017
@dstansby
Copy link
Copy Markdown
Member

dstansby commented Mar 2, 2017

This looks like your first contribution to Matplotlib @epintozzi, thanks a lot!

dstansby added a commit that referenced this pull request Mar 2, 2017
@dstansby
Copy link
Copy Markdown
Member

dstansby commented Mar 2, 2017

Backported to 2.0.0-doc via. 6e52c51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

X Tutup