merge streamplot_demo_features streamplot_demo_masking streamplot_demo_start_points#8155
merge streamplot_demo_features streamplot_demo_masking streamplot_demo_start_points#8155patniharshit wants to merge 1 commit intomatplotlib:masterfrom
Conversation
| @@ -31,3 +31,56 @@ | |||
| ax2.streamplot(X, Y, U, V, density=0.6, color='k', linewidth=lw) | |||
|
|
|||
| plt.show() | |||
There was a problem hiding this comment.
Remove; there's one at the end.
|
|
||
| """ | ||
| ================================ | ||
| Streamplot function with masking |
There was a problem hiding this comment.
You'll need to merge this docstring with the one at the beginning to make something coherent.
| masked regions and NaN values. | ||
| """ | ||
| w = 3 | ||
| Y, X = np.mgrid[-w:w:100j, -w:w:100j] |
There was a problem hiding this comment.
Can X and Y be reused from above?
| ax.imshow(~mask, extent=(-w, w, -w, w), alpha=0.5, | ||
| interpolation='nearest', cmap=plt.cm.gray) | ||
|
|
||
| plt.show() |
|
|
||
| """ | ||
| ======================================== | ||
| Streamplot function with starting points |
There was a problem hiding this comment.
Again, you need to merge this with the first docstring.
| """ | ||
| Y, X = np.mgrid[-3:3:100j, -3:3:100j] | ||
| U = -1 - X**2 + Y | ||
| V = 1 + X - Y**2 |
There was a problem hiding this comment.
Can any of these be reused from before?
|
Wouldn't this be a duplicate effort of #8082? |
|
@afvincent @QuLogic Should I continue with the suggested changes in review? |
|
I suggest combining efforts with @tmcclintock . The comments between the two PRs are very similar. I suggest starting from the branch in #8082 , addressing both sets of comments and opening a new PR with the combined efforts. |
|
@patniharshit I agree with @tacaswell on the idea of merging the two PRs. In the case where some review comments about English are overlapping between @QuLogic's ones and mine, just trust @QuLogic ;). |
|
Replaced by #8336. |
4 participants
refs #7956