Drop None from Container.get_children().#8119
Merged
NelleV merged 1 commit intomatplotlib:masterfrom Feb 22, 2017
Merged
Conversation
Before the patch, ``` ec = plt.errorbar([1, 2], [3, 4], [5, 6], capsize=2, fmt="none") print(ec.get_children()) ``` would print `None` (corresponding to the "not drawn" line connecting the data points), two `Line2D` and one `LineCollection`. This patch drops the `None` out, as it is arguably not a child of the Container. (It is still possible to access the individual members of the Container by unpacking it as a tuple.) Also reformat an overly indented piece of code in the vicinity.
Member
|
So now it'll return an empty list? Am I reading that right? Containers are hardly tested. Could we add some to cover this case? |
tacaswell
approved these changes
Feb 21, 2017
Contributor
Author
|
@phobson Yes, yes, and go ahead :) |
Member
|
Does this need an api change note? |
Contributor
Author
|
Technically the API doesn't change (you can't rely on indexing the results of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before the patch,
would print
None(corresponding to the "not drawn" line connecting thedata points), two
Line2Dand oneLineCollection.This patch drops the
Noneout, as it is arguably not a child of theContainer. (It is still possible to access the individual members of
the Container by unpacking it as a tuple.)
Also reformat an overly indented piece of code in the vicinity.