Improve error message for image_comparison decorator.#8096
Merged
NelleV merged 1 commit intomatplotlib:masterfrom Feb 18, 2017
Merged
Conversation
The name of the test is already reported by pytest; the mismatching number of images is more useful. If a non-callable is passed to the decorator the test will fail normally and be reported as such by pytest; no need to check for it.
dstansby
reviewed
Feb 18, 2017
Member
dstansby
left a comment
dstansby
left a comment
There was a problem hiding this comment.
👍 Looks good to me (and it works too!)
dstansby
approved these changes
Feb 18, 2017
dstansby
changed the title
NelleV
approved these changes
Feb 18, 2017
QuLogic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The name of the test is already reported by pytest; the mismatching
number of images is more useful.
If a non-callable is passed to the decorator the test will fail
normally and be reported as such by pytest; no need to check for it.