Correctly close glyph contours that use curves.#8028
Merged
NelleV merged 3 commits intomatplotlib:v2.0.xfrom Mar 15, 2017
Merged
Correctly close glyph contours that use curves.#8028NelleV merged 3 commits intomatplotlib:v2.0.xfrom
NelleV merged 3 commits intomatplotlib:v2.0.xfrom
Conversation
I've tried this out on the first ~2000 characters (though not all are available in DejaVu Sans), and it doesn't seem to break anything. Fixes matplotlib#7227.
Member
|
I suspect that the failing tests have the wrong paths encoded in them. |
Member
Author
|
Yes, I knew I should have checked the full test results before-hand. They are slightly different, e.g., at the top of the 0, which points to the same issue. |
dopplershift
approved these changes
Feb 6, 2017
dopplershift
changed the title
tacaswell
approved these changes
Feb 7, 2017
Member
|
attn @mdboom |
Member
|
I am happy with this and willing to merge it, but would like to give Mike a chance to look at it. |
tacaswell
changed the title
QuLogic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've tried this out on the first ~2000 characters (though not all are available in DejaVu Sans), and it doesn't seem to break anything.
Fixes #7227.