Catch specgram warnings during tests #7985
Merged
QuLogic merged 6 commits intomatplotlib:masterfrom Feb 6, 2017
DietBru:fix_specgram_Userwarning
Merged
Catch specgram warnings during tests #7985QuLogic merged 6 commits intomatplotlib:masterfrom DietBru:fix_specgram_Userwarning
QuLogic merged 6 commits intomatplotlib:masterfrom
DietBru:fix_specgram_Userwarning
Conversation
anntzer
reviewed
Jan 30, 2017
lib/matplotlib/tests/test_mlab.py
Outdated
| '07/09/83 5:17:34 PM\n' + | ||
| '06/20/2054 2:31:45 PM\n' + | ||
| '10/31/00 11:50:23 AM\n') | ||
| '03/05/76 12:00:01 AM\n' + |
Contributor
There was a problem hiding this comment.
You may as well remove the "+" to rely on implicit string concatenation.
anntzer
reviewed
Jan 30, 2017
lib/matplotlib/tests/test_mlab.py
Outdated
| assert spec.shape[1] == self.t_specgram.shape[0] | ||
|
|
||
| def test_specgram_warn_only1seg(self): | ||
| """Warning should be raised if len(x) <= len(NFFT). """ |
dstansby
requested changes
Feb 1, 2017
Member
dstansby
left a comment
dstansby
left a comment
There was a problem hiding this comment.
Looks good, apart from the extra warning statement needed
| def test_specgram_warn_only1seg(self): | ||
| """Warning should be raised if len(x) <= NFFT. """ | ||
| with warnings.catch_warnings(record=True) as w: | ||
| mlab.specgram(x=self.y, NFFT=len(self.y), Fs=self.Fs) |
Member
There was a problem hiding this comment.
Just before this line will need a line with
warnings.simplefilter('always')
dstansby
approved these changes
Feb 2, 2017
dstansby
changed the title
Member
|
This all looks good now. To reviewer+1: I can't get the old warnings to appear using pytest on master anymore, does anyone know why this is? |
Member
|
I think pytest does a better job of capturing output than nose did; you can try passing |
Member
|
Yep, I'm picking them up with the pytest-warnings plugin now. |
dstansby
approved these changes
Feb 3, 2017
QuLogic
changed the title
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Jun 1, 2017
The nosig_complex_twosided_nopad_to and nosig_complex_defaultsided_nopad_to tests appear to have been mistakes, because they repeat the parameters used in nosig_complex_twosided_noNFFT_no_pad_to and nosig_complex_defaultsided_noNFFT_no_pad_to, so change `None` to `-1`. The nosig_complex_defaultsided_trim test was somehow not causing warnings and thus not "fixed" by matplotlib#7985, but change it `len_x=1024` and `NFFT_density=512` to be consistent with the other tests. The nosig_complex_defaultsided_oddlen test has always been different from its sibling tests and I suspect it was an accident, so change `NFFT_density` to 33. Fixes matplotlib#8393.
QuLogic
added a commit
to QuLogic/matplotlib
that referenced
this pull request
Jun 2, 2017
The nosig_complex_twosided_nopad_to and nosig_complex_defaultsided_nopad_to tests appear to have been mistakes, because they repeat the parameters used in nosig_complex_twosided_noNFFT_no_pad_to and nosig_complex_defaultsided_noNFFT_no_pad_to, so change `None` to `-1`. The nosig_complex_defaultsided_trim test was somehow not causing warnings and thus not "fixed" by matplotlib#7985, but change it `len_x=1024` and `NFFT_density=512` to be consistent with the other tests. The nosig_complex_defaultsided_oddlen test has always been different from its sibling tests and I suspect it was an accident, so change `NFFT_density` to 33. Fixes matplotlib#8393.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This catches the
specgram()warning introduced in #7845 intest_mlab. Also an additional test was added to check if the warning is raised. Closes #7967.