Convert remaining tests to pytest#7932
Merged
NelleV merged 5 commits intomatplotlib:masterfrom Jan 24, 2017
Merged
Conversation
Member
|
I haven't dug into why, but this is the line currently giving you trouble: |
Member
Author
|
Ah yes, pytest runs pep8 already; we can drop that test eventually, but for now I'll just remove that line. |
Member
|
Maybe this as well? |
Member
Author
|
Bleh, should be fixed now. Can't wait till we can drop this set of tests. |
Current coverage is 62.08% (diff: 100%)@@ master #7932 diff @@
==========================================
Files 175 175
Lines 56124 56124
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 34842 34844 +2
+ Misses 21282 21280 -2
Partials 0 0
|
The former requires nose.
QuLogic
changed the title
NelleV
approved these changes
Jan 24, 2017
phobson
changed the title
phobson
reviewed
Jan 24, 2017
Member
phobson
left a comment
phobson
left a comment
There was a problem hiding this comment.
Looks good to me.
It appears like the test failure is unrelated to this PR. Would like another set of eyes on that, though.
QuLogic
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also delete the
nosebit at the end of some other tests.